contrithanks: Make the script exit after printing usage instructions #4883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielgustafsson
approved these changes
Feb 5, 2020
|
I actually think it should do the equivalent of 5296abe without a tag and only show the usage on |
That makes sense, but still exiting on actual usage printing as per this diff. |
gevaerts
force-pushed
the
contrithanks-usage
branch
from
a2ace5d
to
3010a7f
Compare
|
I somehow hadn't noticed that contributors.sh was different, even though I checked it for exit usage... You are of course right! |
gevaerts
force-pushed
the
contrithanks-usage
branch
from
3010a7f
to
fb6bea1
Compare
bagder
reviewed
Feb 5, 2020
gevaerts
force-pushed
the
contrithanks-usage
branch
from
fb6bea1
to
fc06145
Compare
bagder
approved these changes
Feb 5, 2020
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.