Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using strlen for testing if a string is empty #4873

Closed
wants to merge 1 commit into from
Closed

Avoid using strlen for testing if a string is empty #4873

wants to merge 1 commit into from

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Feb 3, 2020

No description provided.

danielgustafsson
danielgustafsson approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@danielgustafsson danielgustafsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There doesn't seem to be any other instances of this pattern AFAICT from a quick scan through the tree.

@orgads
Copy link
Contributor Author

orgads commented Feb 3, 2020

Wait, I found a few others :)

@orgads
Copy link
Contributor Author

orgads commented Feb 3, 2020

Wait, there's more.

@orgads
Copy link
Contributor Author

orgads commented Feb 3, 2020

Ok, I'm done.

danielgustafsson
danielgustafsson reviewed Feb 3, 2020
View reviewed changes
tests/unit/unit1652.c Outdated Show resolved Hide resolved
docs/examples/synctime.c Outdated Show resolved Hide resolved
@bagder
Copy link
Member

bagder commented Feb 4, 2020

Thanks!

@bagder bagder closed this in 2bc3737 Feb 4, 2020
@orgads orgads deleted the no-strlen-for-empty branch February 4, 2020 07:28
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danielgustafsson danielgustafsson danielgustafsson approved these changes

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orgads @bagder @danielgustafsson