FindLibSSH2: add "libssh2" as possible name for library #4804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows systems, libSSH2 CMake installation may name the library "LibSSH2".
Closed
4 tasks
|
When is this necessary? |
|
As I want to rebuild libcurl to use it for sftp, in my project, running in
a Windows / Visual Studio / CMake / Conan environment.
When build using conan and cmake, the libssh2 target is not ssh2, but
libssh2.
As libssh2 is not found, we cannot rebuilt libcurl using it.
However, it is still possible to patch libcurl in the conan-center recipe
(as I proposed here: conan-io/conan-center-index#642 ).
|
|
I guess this is because of: |
|
Yes it seems so.
Then, is it acceptable to search for both ssh2 and libssh2 ?
On linux though it will look for libssh2 and liblibssh2.
|
bagder
approved these changes
Jan 10, 2020
|
I guess it's OK. They use this technique in the official guide: |
|
Thanks |
|
Thank you all :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LibSSH2 CMake installation may name the library "libssh2" instead of "ssh2".