vtls: Refactor Curl_multissl_version to make the code clearer #4803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
approved these changes
Jan 10, 2020
dscho
reviewed
Jan 10, 2020
There was a problem hiding this comment.
I am slightly concerned by the segmentation fault in Travis but could not quickly verify whether this patch is the cause.
|
Unfortunately, the arm64 builds on travis are totally unreliable and do these seemingly random segfaults every now and then. I've never managed to reproduce them when manually running the tests on arm64 machines. |
Reported-by: Johannes Schindelin Ref: curl#3863 (review)
jay
force-pushed
the
refactor_Curl_multissl_version
branch
from
2e8a636
to
ba48050
Compare
dscho
approved these changes
Jan 10, 2020
@bagder thank you for clarifying! |
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported-by: Johannes Schindelin
Ref: #3863 (review)
/cc @dscho