Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

public headers use non-curl prefixed symbols #4793

Closed
bagder opened this issue Jan 7, 2020 · 1 comment
Closed

public headers use non-curl prefixed symbols #4793

bagder opened this issue Jan 7, 2020 · 1 comment
Assignees
@bagder
Labels
libcurl API

Comments

@bagder
Copy link
Member

bagder commented Jan 7, 2020

All symbols curl defines and provides in public include files/headers should be prefixed by curl or libcurl to minimize the risk of them colliding with other libraries' or applications' symbols.

This is mostly done already with a few exceptions (WIN32, CINIT, CFINIT and some of the related defines around the CINIT macro dance). This should be fixed and we should introduce a test that verifies that we maintain this situation going forward.
@bagder bagder self-assigned this Jan 7, 2020
bagder added a commit that referenced this issue Jan 7, 2020
@bagder
test1167: verify global symbols in public headers are curl prefixed
7353dfa 
... using the new badsymbols.pl perl script

Fixes #4793
@bagder bagder mentioned this issue Jan 7, 2020
Closed
@bagder
Copy link
Member Author

bagder commented Jan 7, 2020

What triggered me to go down this rabbit hole this time here was how this mistake slipped in. the fix

bagder added a commit that referenced this issue Jan 7, 2020
@bagder
test1167: verify global symbols in public headers are curl prefixed
536d9ce 
... using the new badsymbols.pl perl script

Fixes #4793
Closes #4794
@bagder bagder closed this as completed in fb723fd Jan 9, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bagder bagder

Labels
libcurl API
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make all public symbols curl prefixed curl/curl
1 participant
@bagder