Add CURL_STATICLIB warning to static linking instructions. #4721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help with future users to prevent some head-scratching and keyboard-smashing.
|
This is already covered in INSTALL.md and in the FAQ. Why do we need it in the build notes? |
|
@jay I appreciate that having information increases the upkeep of said knowledge. My thought is that putting this critical bit adjacent to the windows readme info (where some information is already being duplicated regardless) can only help prevent unnecessary time wasted. Perhaps, ideally, a wiki could get around this by linking between info but, easier would be to include this critical "gotcha" in the document for the time being. That's just my 2 cents so feel free to disregard. Have a great day! |
|
Ref: #4716 Ok. I went with a different wording that is close to that in the FAQ. |
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help with future users to prevent some head-scratching and keyboard-smashing.