Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getinfo: Fix return code for unknown CURLINFO options #468

Closed
wants to merge 1 commit into from
Closed

getinfo: Fix return code for unknown CURLINFO options #468

wants to merge 1 commit into from

Conversation

jay
Copy link
Member

@jay jay commented Oct 1, 2015

  • If a CURLINFO option is unknown return CURLE_UNKNOWN_OPTION.

Prior to this change CURLE_BAD_FUNCTION_ARGUMENT was returned on
unknown. That return value is contradicted by the CURLINFO option
documentation which specifies a return of CURLE_UNKNOWN_OPTION on
unknown.

@jay
getinfo: Fix return code for unknown CURLINFO options
acce6ea 
- If a CURLINFO option is unknown return CURLE_UNKNOWN_OPTION.

Prior to this change CURLE_BAD_FUNCTION_ARGUMENT was returned on
unknown. That return value is contradicted by the CURLINFO option
documentation which specifies a return of CURLE_UNKNOWN_OPTION on
unknown.
@bagder
Copy link
Member

bagder commented Oct 4, 2015

+1

@jay
Copy link
Member Author

jay commented Oct 4, 2015

Thanks for the review, landed in 69ea579.

@jay jay closed this Oct 4, 2015
@jay jay deleted the fix_curlinfo_unknown_option branch October 4, 2015 21:38
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jay @bagder