schannel.c ignores tls-max when tlsv1.x isn't set #4633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you run `curl --tls-max 1.1 https://example.com` on Windows using SChannel, curl incorrectly ignores the `--tls-max 1.1` argument, and it uses TLS 1.2 instead. This patch fixes it by using `set_ssl_version_min_max` to set `grbitEnabledProtocols` when `conn->ssl_config.version` is CURL_SSLVERSION_DEFAULT and `CURL_SSLVERSION_TLSv1`
|
Thanks |
|
Thank you for accepting this PR! This is my first patch to curl. Will my name be added to https://curl.haxx.se/docs/thanks.html? |
|
@xiaoyinl yes it will! We typically update that file ( |
|
@bagder I see. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you run
curl --tls-max 1.1 https://example.comon Windows using SChannel, curl incorrectly ignores the--tls-max 1.1argument, and it uses TLS 1.2 instead.This patch fixes it by using
set_ssl_version_min_maxto setgrbitEnabledProtocolswhenconn->ssl_config.versionis CURL_SSLVERSION_DEFAULT andCURL_SSLVERSION_TLSv1