Ensure HTTP 429 triggers --retry #4465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't be alarmed by the red CI build(s), that's just due to flaky/bad environments and not because of any flaw in your PR. Ignore them. |
|
Thanks! |
stain
added a commit
to stain/ro-index-paper
that referenced
this pull request
Oct 7, 2019
stain
added a commit
to stain/ro-index-paper
that referenced
this pull request
Nov 7, 2019
incorporates curl/curl#4465 and curl/curl#4498
stain
added a commit
to stain/ro-index-paper
that referenced
this pull request
Nov 7, 2019
This build is based on 7c2f8c0. This commit was created by the following Travis CI build and job: https://travis-ci.com/stain/ro-index-paper/builds/135475492 https://travis-ci.com/stain/ro-index-paper/jobs/254097570 [ci skip] The full commit message that triggered this build is copied below: Use latest curl release 7.67.7 incorporates curl/curl#4465 and curl/curl#4498
stain
added a commit
to stain/ro-index-paper
that referenced
this pull request
Nov 7, 2019
This build is based on 7c2f8c0. This commit was created by the following Travis CI build and job: https://travis-ci.com/stain/ro-index-paper/builds/135475492 https://travis-ci.com/stain/ro-index-paper/jobs/254097570 [ci skip] The full commit message that triggered this build is copied below: Use latest curl release 7.67.7 incorporates curl/curl#4465 and curl/curl#4498
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes #3794 by making the
--retrylogic be triggered also onHTTP/1.1 429 Too Many Requestsfrom RFC6586 e.g. as used by Zenodo API and as initially mentioned in #3794 by john-hascall.Also make sure the new tests from #4195 are enabled (although the existing tests seemed to worked fine even modified for 429 status code, as the handling logic is in
src/tool_operate.cwas not involved by test?)Note that the caller still needs to use
--retry nto enable handling of theRetry-Afterheader.