Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option ENABLE_UNICODE to winbuild/Makefile.vc #4308

Closed
apique13 opened this issue Sep 9, 2019 · 1 comment
Closed

Add an option ENABLE_UNICODE to winbuild/Makefile.vc #4308

apique13 opened this issue Sep 9, 2019 · 1 comment
Labels

Comments

@apique13
Copy link

apique13 commented Sep 9, 2019

I did this

I used the "nmake /f Makefile.vc ..." script in WinBuild folder to build libcurl.dll.
But with this dll, I couldn't use ldap requests with special characters in the query parameters.
In french Active Directory, we have some "nice" OU attributes : "Groupes de sécurité" ... :-(

I rebuild the libcurl.dll with forcing UNICODE with the parameter /DUNICODE in CFLAGS.
And now it works.
I use unicode in my app, I prefer continue using it to request the ldap server instead of converting it to current locale. I'm not sure which locale is used by the destination ldap server.

I expected the following

It thinks it should be nice to add a parameter "ENABLE_UNICODE=" to winbuild/Makefile.vc.
I will send a pull request, I already did it for myself

curl/libcurl version

curl 7.55.1 (Windows) libcurl/7.55.1 WinSSL
Release-Date: [unreleased]
Protocols: dict file ftp ftps http https imap imaps pop3 pop3s smtp smtps telnet tftp
Features: AsynchDNS IPv6 Largefile SSPI Kerberos SPNEGO NTLM SSL

operating system

Windows 10 x64

@apique13
Copy link
Author

apique13 commented Sep 9, 2019

[https://github.com//pull/4309]

@bagder bagder added the build label Sep 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

2 participants