Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress meter is gone in 7.65.2 #4122

Closed
yan12125 opened this issue Jul 18, 2019 · 3 comments
Closed

Progress meter is gone in 7.65.2 #4122

yan12125 opened this issue Jul 18, 2019 · 3 comments
Labels
regression

Comments

@yan12125
Copy link

I did this

curl https://example.com > index.html

I expected the following

curl prints progress

$ curl https://example.com > index.html
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1270  100  1270    0     0   2247      0 --:--:-- --:--:-- --:--:--  2247

This is the result from 7.65.1. With 7.65.2 the command prints nothing but a newline. Looking at the changelog, there is an item configure: --disable-progress-meter. From the linked commit 21080e1, I think the progress meter is still enabled by default?

curl/libcurl version

$ curl -V
curl 7.65.2 (x86_64-pc-linux-gnu) libcurl/7.65.2 OpenSSL/1.1.1c zlib/1.2.11 libidn2/2.2.0 libpsl/0.21.0 (+libidn2/2.2.0) libssh2/1.8.2 nghttp2/1.39.1
Release-Date: 2019-07-17
Protocols: dict file ftp ftps gopher http https imap imaps pop3 pop3s rtsp scp sftp smb smbs smtp smtps telnet tftp 
Features: AsynchDNS GSS-API HTTP2 HTTPS-proxy IDN IPv6 Kerberos Largefile libz NTLM NTLM_WB PSL SPNEGO SSL TLS-SRP UnixSockets

operating system

Arch Linux with testing repositories enabled
@kdudka
Copy link
Contributor

kdudka commented Jul 18, 2019

This is indeed caused by commit 21080e1. I did not find any way to re-enable the progress meter. The program logic seems to be broken: progress_calc() sets data->progress.lastshow = now.tv_sec which prevents the condition data->progress.lastshow != now.tv_sec in progress_meter() from being satisfied later on.

While debugging this, I would have appreciated if the move code around and actually change the behavior had been two separate commits.

@bagder
Copy link
Member

bagder commented Jul 18, 2019

Grrr. Worth a patch release for the fix methinks...

bagder added a commit that referenced this issue Jul 18, 2019
@bagder
progress: make the progress meter appear again
157c492 
Fix regression caused by 21080e1

Reported-by: Chih-Hsuan Yen
Fixes #4122
@bagder bagder mentioned this issue Jul 18, 2019
Closed
@bagder bagder closed this as completed in 27e14ef Jul 19, 2019
@yan12125
Copy link
Author

Thanks for the fast update! I can confirm 7.65.3 works fine.

caraitto pushed a commit to caraitto/curl that referenced this issue Jul 23, 2019
@bagder @caraitto
progress: make the progress meter appear again
0b9bd6e 
Fix regression caused by 21080e1

Reported-by: Chih-Hsuan Yen
Fixes curl#4122
Closes curl#4124
@lock lock bot locked as resolved and limited conversation to collaborators Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
regression
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

progress: make the progress meter appear again curl/curl
3 participants
@bagder @kdudka @yan12125