Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent brotli package name in CMake #4117

Closed
aasivov opened this issue Jul 16, 2019 · 1 comment
Closed

Inconsistent brotli package name in CMake #4117

aasivov opened this issue Jul 16, 2019 · 1 comment
Labels
cmake

Comments

@aasivov
Copy link
Contributor

aasivov commented Jul 16, 2019

It seems that brotli package name is inconsistent in cmake files.
CMakeLists.txt contains string find_package(BROTLI QUIET)
but there is a file CMake/FindBrotli.cmake

It seems that either CMake/FindBrotli.cmake should be renamed to CMake/FindBROTLI.cmake or find_package(BROTLI QUIET) should be replaced with find_package(Brotli QUIET)

Otherwise find_package fails to find brotli on Linux machine with the following message:

By not providing "FindBROTLI.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "BROTLI", but
CMake did not find one.

Could not find a package configuration file provided by "BROTLI" with any
of the following names:

BROTLIConfig.cmake
brotli-config.cmake

Add the installation prefix of "BROTLI" to CMAKE_PREFIX_PATH or set
"BROTLI_DIR" to a directory containing one of the above files. If "BROTLI"
provides a separate development package or SDK, be sure it has been
installed.
@bagder bagder added the cmake label Jul 16, 2019
@jay jay closed this as completed in 2527eca Jul 17, 2019
@jay
Copy link
Member

jay commented Jul 17, 2019

Thanks

caraitto pushed a commit to caraitto/curl that referenced this issue Jul 23, 2019
@aasivov @caraitto
cmake: Fix finding Brotli on case-sensitive file systems
dba4af1 
- Find package "Brotli" instead of "BROTLI" since the former is the
  casing used for CMake/FindBrotli.cmake, and otherwise find_package
  may fail on a case-sensitive file system.

Fixes curl#4117
@lock lock bot locked as resolved and limited conversation to collaborators Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
cmake
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bagder @jay @aasivov