Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix outdated string suggesting HTTP/2 is not the default #4075

Closed
wants to merge 1 commit into from

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Jun 25, 2019

Commit 25fd105
made HTTP2 the default, and further down in the man page that new default
is mentioned, but the section at the top contradicted it until now.

This caused some confusion with libcurl users, for example in NixOS/nix#2971.

docs/libcurl/opts/CURLOPT_HTTP_VERSION.3 Outdated Show resolved Hide resolved
Commit 25fd105
made HTTP2 the default, and further down in the man page that new default
is mentioned, but the section at the top contradicted it until now.

Also remove claim that setting the HTTP version is not sensible.
@bagder
Copy link
Member

bagder commented Jun 25, 2019

Thanks!

@bagder bagder closed this in 8dd041b Jun 25, 2019
@nh2
Copy link
Contributor Author

nh2 commented Jun 25, 2019

Thanks!

Copy link

@aniketd aniketd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants