--disable-progress-meter #4023
Closed
--disable-progress-meter #4023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
force-pushed
the
bagder/disable-progress-meter
branch
from
0d66782
to
1189269
Compare
|
Why is a compile-time option needed to disable the progress meter? |
|
It completely removes the support for the progress meter from the build. |
|
Yeah but why, did you do it for size? |
|
Yes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a new take at allowing a build to disable the progress meter. The previous attempt was reverted in #3928 due to regressions.
My plan is to take the bug report from #3927 and make a test case out of it to verify that this PR doesn't break existing functionality (in the same way) before I merge.