ssl: Update outdated "openssl-only" comments for supported backends #3985
Conversation
include/curl/curl.h
Outdated
| void *ssl_ctx, /* actually an | ||
| OpenSSL SSL_CTX */ | ||
| void *ssl_ctx, /* actually an OpenSSL | ||
| or WolfSSL SSL_CTX, |
There was a problem hiding this comment.
Is there space here within our 80 character limit to align the first character of each addition comment line with the start to actually?
There was a problem hiding this comment.
For these lines, yes, but the "mbedtls_ssl_config */" line would be too long then. I'll have just that one be "wrong"
include/curl/curl.h
Outdated
| in second argument. The function must be matching the | ||
| curl_ssl_ctx_callback proto. */ | ||
| /* Set the ssl context callback function, currently only for OpenSSL or | ||
| WolfSSL ssl_ctx or mbedTLS mbedtls_ssl_config in second argument. |
There was a problem hiding this comment.
I would insert the old "oxford comma" between ssl_ctx and or, and a the between in and second.
There was a problem hiding this comment.
Yes, good point (or comma!)
include/curl/curl.h
Outdated
| curl_ssl_ctx_callback proto. */ | ||
| /* Set the ssl context callback function, currently only for OpenSSL or | ||
| WolfSSL ssl_ctx or mbedTLS mbedtls_ssl_config in second argument. | ||
| The function must be matching the curl_ssl_ctx_callback proto. */ |
There was a problem hiding this comment.
I think the sentence reads better if be matching is replaced with match and proto is expanded to prototype.
There was a problem hiding this comment.
True, and worth changing while we're at it.
captain-caveman2k
changed the title
These are for features that used to be openssl-only but were expanded over time.
These are for features that used to be openssl-only but were expanded over
time.