Add missing set_in_callback around callback. #3837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
approved these changes
May 4, 2019
|
Thanks! |
|
I noticed that after upgrading to curl 7.65.0, netsurf isn't working with HTTP redirects, and I bisected it down to this commit. After some investigation, it looks like this is because netsurf is calling I guess this is the sort of thing this commit is intended to prevent? Just wanted to check before submitting a netsurf bug report. |
Yes that was the intention, please refer to the discussion in #2302. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happened to find a callback not surrounded by the
Curl_set_in_callbackfunctions.