Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tool_help: Warn if curl and libcurl versions do not match #3774

Closed
wants to merge 1 commit into from
Closed

tool_help: Warn if curl and libcurl versions do not match #3774

wants to merge 1 commit into from

Conversation

jay
Copy link
Member

@jay jay commented Apr 13, 2019

.. because functionality may be affected if the versions differ.

This commit implements TODO 18.7 "warning if curl version is not in sync
with libcurl version".

Ref: https://github.com/curl/curl/blob/curl-7_64_1/docs/TODO#L1028-L1033

Closes #xxxx

For example:

curl 7.65.0-DEV (i386-pc-win32) libcurl/7.64.0-DEV Schannel WinIDN
Release-Date: [unreleased]
Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps pop3 pop3s rtsp smb smbs smtp smtps telnet tftp
Features: AsynchDNS Debug IDN IPv6 Kerberos Largefile NTLM SPNEGO SSL SSPI
WARNING: curl and libcurl versions do not match. Functionality may be affected.

@jay
tool_help: Warn if curl and libcurl versions do not match
8ef7575 
.. because functionality may be affected if the versions differ.

This commit implements TODO 18.7 "warning if curl version is not in sync
with libcurl version".

Ref: https://github.com/curl/curl/blob/curl-7_64_1/docs/TODO#L1028-L1033

Closes #xxxx
bagder
bagder approved these changes Apr 13, 2019
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jay jay closed this in 538db66 Apr 16, 2019
@jay jay deleted the warn_version_mismatch branch April 16, 2019 07:11
@lock lock bot locked as resolved and limited conversation to collaborators Jul 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
cmdline tool
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jay @bagder