tests/server/util: fix Windows Unicode build #3758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always use the ANSI version of FormatMessage as we don't have the curl_multibyte gear available here. Closes
|
It seems like a straight forward fix. It has my thumbs up. It might be worth considering the use of curl_multibyte in future though. Looking at Makefile.inc we could potentially add it to CURLX_SRCS and CURLX_INCS. |
captain-caveman2k
approved these changes
Apr 11, 2019
|
Thanks! I'll look into that. |
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
Apr 14, 2019
This will also be needed in the tool and tests. Ref: curl#3758 (comment) Closes
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
Apr 14, 2019
Now that we have the multibyte gear available in the tests, we can use the proper Unicode version of the function. Ref: curl#3758 (comment) Closes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always use the ANSI version of FormatMessage as we don't have the
curl_multibyte gear available here.