Fix Codacy warnings #3739
Closed
Fix Codacy warnings #3739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any area keyword I can use in the commit titles when touching everything, including even the packages directory? I haven't found one consistently used. |
my opinion - use |
MarcelRaad
commented
Apr 5, 2019
Thanks @jay , makes sense! |
Consistently use one blank line between blocks. Closes curl#3739
These variables are only conditionally initialized. Closes curl#3739
Make functions no-ops if neither both USE_THREADS_POSIX and HAVE_PTHREAD_H nor both USE_THREADS_WIN32 and HAVE_PROCESS_H are defined. Previously, if only one of them was defined, there was either code compiled that did nothing useful or the wrong header included for the functions used. Also, move POLARSSL_MUTEX_T define to implementation file as it's not used externally. Closes curl#3739
- remove unused variables - declare conditionally used variables conditionally - suppress unused variable warnings in the CMake tests - remove dead variable stores - consistently use WIN32 macro to detect Windows Closes curl#3739
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
Apr 11, 2019
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
Apr 11, 2019
These variables are only conditionally initialized. Closes curl#3739
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
Apr 11, 2019
Make functions no-ops if neither both USE_THREADS_POSIX and HAVE_PTHREAD_H nor both USE_THREADS_WIN32 and HAVE_PROCESS_H are defined. Previously, if only one of them was defined, there was either code compiled that did nothing useful or the wrong header included for the functions used. Also, move POLARSSL_MUTEX_T define to implementation file as it's not used externally. Closes curl#3739
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
Apr 11, 2019
- remove unused variables - declare conditionally used variables conditionally - suppress unused variable warnings in the CMake tests - remove dead variable stores - consistently use WIN32 macro to detect Windows Closes curl#3739
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly from CppCheck. Some fixes for unused local variable warnings would have been nicer with C99, being able to declare them in the right preprocessor condition block.