New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set SSL_BACKENDS from cmake build #3736
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! This should also fix test 1014 on AppVeyor for the WinSSL and OpenSSL builds.
Unfortunately, the CMake build failed for the non-SSL builds on AppVeyor:
|
Thanks @MarcelRaad! Hmm, looks like due to the lack of a proper type system, there is no way to create an empty list. So we need to check if the variable is empty before trying to sort, which adds 2 additional lines for each of those lists. I'll do that later today or tomorrow if nobody has a better idea that allows us to call sort on every element count |
In case of an empty list, SORTing leads to the cmake error "list sub-command SORT requires list to be present."
This groups all SSL backends into the feature "SSL" and sets the SSL_BACKENDS analogue to configure.ac
57e6aa7
to
4d352c9
Compare
I could reproduce the problem locally with no SSL backend enabled and fixed it now. |
Great, thanks! The AppVeyor failures are only the usual "slow response" tests, so I'm merging now. |
This groups all SSL backends into the feature "SSL" and sets the SSL_BACKENDS analogue to configure.ac Closes curl#3736
This groups all SSL backends into the feature "SSL" and sets the SSL_BACKENDS analogue to configure.ac.
This is a preparation for #3733 but independent of the DarwinSSL issue.
Before
After