Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test 2043 can never be run #3609

Closed
MarcelRaad opened this issue Feb 25, 2019 · 2 comments
Closed

Test 2043 can never be run #3609

MarcelRaad opened this issue Feb 25, 2019 · 2 comments
Labels
tests TLS Windows Windows-specific

Comments

@MarcelRaad
Copy link
Member

I did this

./configure --enable-debug --without-ssl --with-winssl --enable-static --disable-shared && make && cd tests && make && ./runtests.pl 2043

Results in:

test 2043 SKIPPED: curl lacks WinSSL support

The test was added in 172b2be#diff-4dd1fa7586ffcf4267ac687f7604d9b7.

I expected the following

The test to be run.

Probably related, test 1014 says:

test 1014...[Compare curl --version with curl-config --features]
Mismatch in features lists:
curl:        asynchdns ipv6 kerberos ntlm spnego ssl sspi
curl-config: asynchdns ipv6 kerberos ntlm spnego sspi winssl

curl/libcurl version

********* System characteristics ********
* curl 7.64.1-20190225 (i686-w64-mingw32)
* libcurl/7.64.1-20190225 Schannel
* Features: AsynchDNS Debug TrackMemory IPv6 Largefile SSPI Kerberos SPNEGO NTLM SSL
* Host: DevBuild-MS1
* System: MINGW32_NT-10.0 DevBuild-MS1 2.10.0(0.325/5/3) 2018-02-09 15:25 x86_64 Msys
*
*** DISABLES memory tracking when using threaded resolver
*
* Servers: HTTP-IPv6 FTP-IPv6
* Env:
* Ports:
* HTTP/8990 FTP/8992 FTP2/8995 RTSP/9007
* TFTP/8997 HTTP-IPv6/8994 RTSP-IPv6/9008 FTP-IPv6/8996
* GOPHER/9009 GOPHER-IPv6/9010
* SSH/8999 SOCKS/9000 POP3/9001 IMAP/9003 SMTP/9005
* POP3-IPv6/9002 IMAP-IPv6/9004 SMTP-IPv6/9006
* HTTPTLS/9011 HTTPTLS-IPv6/9012
*****************************************

and

********* System characteristics ******** 
* curl 7.64.1-DEV (Windows) 
* libcurl/7.64.1-DEV Schannel
* Features: AsynchDNS Debug TrackMemory IPv6 Largefile SSPI Kerberos SPNEGO NTLM SSL 
* Host: APPVYR-WIN
* System: MSYS_NT-10.0 APPVYR-WIN 2.11.1(0.329/5/3) 2018-09-10 14:19 x86_64 Msys
*
*** DISABLES memory tracking when using threaded resolver
*
* Servers: HTTP-IPv6 FTP-IPv6 
* Env: 
*****************************************

operating system

MSYS2 using MinGW-w64 on Windows 10
@bagder
Copy link
Member

bagder commented Feb 25, 2019 •
edited

The first problem is probably that curl -V now reports "Schannel" and not "winssl":

curl/lib/vtls/schannel.c

Line 2098 in 66637b4

size = msnprintf(buffer, size, "Schannel");

... while runtests.pl still looks for winssl:

curl/tests/runtests.pl

Line 2691 in 66637b4

if ($libcurl =~ /winssl/i) {

It should probably be made to look for both. Tests still depend on "winssl" so we better not break that (or we'd have to update the tests that do, if we want to change to only "schannel").

The test 1014 problem is weird and I haven't yet figured out why it happens. The feature should be "ssl" and not "winssl" but for some reason curl-config doesn't think so...

@bagder bagder added TLS tests Windows Windows-specific labels Feb 25, 2019
bagder added a commit that referenced this issue Feb 26, 2019
@bagder
runtests: detect "schannel" as an alias for "winssl"
d93da7a 
Follow-up to 180501c

Reported-by: Marcel Raad
Fixes #3609
@bagder bagder mentioned this issue Feb 26, 2019
Closed
@bagder
Copy link
Member

bagder commented Feb 26, 2019

@MarcelRaad I'd appreciate if you could give my PR a test and see if that fixes this issue!

MarcelRaad pushed a commit to MarcelRaad/curl that referenced this issue Feb 26, 2019
@bagder @MarcelRaad
runtests: detect "schannel" as an alias for "winssl"
3841de8 
Follow-up to 180501c

Reported-by: Marcel Raad
Fixes curl#3609
@bagder bagder closed this as completed in 15ef249 Feb 26, 2019
@MarcelRaad MarcelRaad mentioned this issue Apr 3, 2019
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
tests TLS Windows Windows-specific
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

runtests: detect "schannel" as an alias for "winssl" curl/curl
2 participants
@bagder @MarcelRaad