OpenSSL: Add support for TLS ASYNC state. #3591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
changed the title
|
I checked. The define |
note that commit doesn't mention SSL_connect for the async |
|
@bermuell do you have a particular use case where you can trigger this failure and the fix then also fixes it? |
|
The use case is when libCurl's SSL_CTX_set_cert_verify_callback is used to verify a cert-chain and the verify procedure is a async call to a PKI instance.
Without this fix the connection is closed by libCurl and reporting related 'WANT_ASYNC' error message. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case that the TLS connection is paused using openssl ASYNC_pause_job()
current implementation of libcurl handles it as a connection error.
The proposed change adds support in case the TLS connections is paused that way.