Generate fish completion file #3545
Conversation
| FISH_FUNCTIONS_DIR="$withval" | ||
| AC_SUBST(FISH_FUNCTIONS_DIR) | ||
| ;; | ||
| esac |
There was a problem hiding this comment.
This will get unwieldy when the third and fourth and .. and ... shell gets added. Is there a way to support the tab completion with a single configure flag invocation? --with-shell-functions={fish|zsh}?
There was a problem hiding this comment.
Maybe someone else with a better understanding of the build system (than me) can investigate (later on)?
There was a problem hiding this comment.
Yes, this can be deferred, potentially till when we want to add a third tab completion target even.
|
The appveyor fail looks totally unrelated - I just won't retrigger a rebuild now because appveyor seems to be awefully slow at the moment so it'll just add many pointless hours of waiting. |
| FISH_FUNCTIONS_DIR="$withval" | ||
| AC_SUBST(FISH_FUNCTIONS_DIR) | ||
| ;; | ||
| esac |
There was a problem hiding this comment.
Yes, this can be deferred, potentially till when we want to add a third tab completion target even.
| if ($shell eq 'fish') { | ||
| print "# curl fish completion\n\n"; | ||
| print qq{$_ \n} foreach (@opts); | ||
| } elsif ($shell eq 'zsh') { |
There was a problem hiding this comment.
This seems to lack an else case erroring out when the shell has been specified to an incorrect value.
There was a problem hiding this comment.
@simon04, any thoughts on this nit?
|
Sure, makes sense! Done. (Sorry for the late reply; I'm in vacation…)
… |
|
Thanks! |
|
For the record... #3723 Fish has a special directory for completions that are installed by thirdparty software and not by fish itself. There is also a pkg-config file to detect that directory. |
This PR adds tab completion for the fish shell.
Reference: https://fishshell.com/docs/current/commands.html#complete
Output: https://gist.github.com/simon04/61f4a944395d32939e8204da376fd4ab