Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: added checks for variadic macros #3459

Merged
merged 1 commit into from Jan 11, 2019
Merged

cmake: added checks for variadic macros #3459

merged 1 commit into from Jan 11, 2019

Conversation

snikulov
Copy link
Member

Added checks for HAVE_VARIADIC_MACROS_C99 and HAVE_VARIADIC_MACROS_GCC to match autoconfig behavior (Ref: acinclude.m4).

Fixes #3142, #3452

@snikulov snikulov added the cmake label Jan 11, 2019
@snikulov snikulov mentioned this pull request Jan 11, 2019
Closed
MarcelRaad
MarcelRaad approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@MarcelRaad MarcelRaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

@snikulov
Copy link
Member Author

@bagder can I merge? Looks like baseline for this fix also failed on AppVeyor

@bagder
Copy link
Member

bagder commented Jan 11, 2019

Go ahead, that failure looked like another false positive and I restarted it now in case you'd rather wait and see.

@snikulov snikulov merged commit 52e27fe into curl:master Jan 11, 2019
@snikulov snikulov deleted the cmake_have_variadic_macro_checks branch January 14, 2019 07:05
@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagder bagder bagder approved these changes

@MarcelRaad MarcelRaad MarcelRaad approved these changes

Assignees
No one assigned
Labels
cmake
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@snikulov @bagder @MarcelRaad