Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cleanup for cyassl #3395

Closed
wants to merge 2 commits into from
Closed

Added cleanup for cyassl #3395

wants to merge 2 commits into from

Conversation

dgarske
Copy link
Contributor

@dgarske dgarske commented Dec 19, 2018

Resolves possible memory leak when using ECC fixed point cache.
Fixes #3387

Copy link
Member

@danielgustafsson danielgustafsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me.

@@ -794,6 +794,12 @@ static int Curl_cyassl_init(void)
}


void Curl_cyassl_cleanup(void)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume checksrc will complain loudly here, should be this I believe:

void
Curl_cyassl_cleanup(void)
{
  CyaSSL_Cleanup();
}

Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@danielgustafsson danielgustafsson self-assigned this Dec 19, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Mar 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak in wolfssl in threaded function
3 participants