Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESCape "\n" codes #3246

Merged
merged 1 commit into from Nov 9, 2018
Merged

ESCape "\n" codes #3246

merged 1 commit into from Nov 9, 2018

Conversation

gvanem
Copy link
Contributor

@gvanem gvanem commented Nov 7, 2018

In a .nf section, Groff / Troff will display a:

 printf("Errno: %ld\n", error);

as:

  printf("Errno: %ld0, error);

when a "\n" is not escaped. Use "\\n" instead.

Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks fine, but please make your commit message follow our standard style. Perhaps:

 CURLINFO_OS_ERRNO.3: escape "\n" codes

@gvanem gvanem changed the title ESCape "\n" codes CURLINFO_OS_ERRNO.3: ESCape "\n" codes Nov 7, 2018
@gvanem gvanem changed the title CURLINFO_OS_ERRNO.3: ESCape "\n" codes CURLOPT_CHUNK_BGN_FUNCTION.3: ESCape "\n" codes Nov 7, 2018
@gvanem gvanem changed the title CURLOPT_CHUNK_BGN_FUNCTION.3: ESCape "\n" codes ESCape "\n" codes Nov 7, 2018
@gvanem
Copy link
Contributor Author

gvanem commented Nov 7, 2018

Too late to edit the commit message now. Only the title is editable. At least here on Github.

@bagder
Copy link
Member

bagder commented Nov 7, 2018

You can always edit the commits in your branch (git rebase -i) and then force-push them to the branch. But once they're merged to master it is too late.

@gvanem
Copy link
Contributor Author

gvanem commented Nov 7, 2018

There's an option here on Github for a Create a merge commit. But it's disabled for curl:
curl_rebase_mergel

So I'm not sure what to do. Or what you want me to do about this PR.

@kdudka
Copy link
Contributor

kdudka commented Nov 7, 2018

@gvanem git rebase -i is a command that you need to run in a terminal.

@gvanem
Copy link
Contributor Author

gvanem commented Nov 8, 2018

@kdudka I know that. But it's a big hassle for me to git pull , edit, commit and push just for this small change. That's why I did it all here at Github (it was easier to contribute to libcurl in the old pre-git days).

Groff / Troff will display a:
 printaf("Errno: %ld\n", error);
as:
  printf("Errno: %ld0, error);

when a "\n" is not escaped. Use "\\n" instead.

Closes #3246
@bagder
Copy link
Member

bagder commented Nov 9, 2018

I disagree with that, but perhaps the biggest change and improvement compared to the "old days" and now is that we run a bazillion tests on the change before we merge it...

I squashed and forced-pushed these commits with a new commit message!

@bagder bagder merged commit 073332b into master Nov 9, 2018
@bagder bagder deleted the escape-codes-docs branch November 9, 2018 16:49
@lock lock bot locked as resolved and limited conversation to collaborators Feb 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants