Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openvms: fix example name #3217

Closed
wants to merge 1 commit into from
Closed

openvms: fix example name #3217

wants to merge 1 commit into from

Conversation

danielgustafsson
Copy link
Member

@danielgustafsson danielgustafsson commented Nov 1, 2018 •
edited

Commit efc696a renamed persistant.c to persistent.c to fix the typo in the name, but missed to update the OpenVMS package files which still used the old name.

@danielgustafsson
openvms: fix example name
a5d4b7a 
Commit efc696a renamed persistant.c to persistent.c to
fix the typo in the name, but missed to update the OpenVMS package
files which still looked for the old name.
@vszakats
Copy link
Member

vszakats commented Nov 2, 2018 •
edited

Thank you @danielgustafsson! I excluded the vms subdir from my codespell update to avoid messing up anything VMS-related (can't test those), and missed this hidden connection — sorry about that.

FWIW here is all codespell finds for that directory, some of them valid, some not necessary:

./packages/vms/gnv_link_curl.com:86: includ  ==> include
./packages/vms/gnv_link_curl.com:743: persistant  ==> persistent
./packages/vms/curl_gnv_build_steps.txt:201: archictecture  ==> architecture
./packages/vms/setup_gnv_curl_build.com:61: includ  ==> include
./packages/vms/setup_gnv_curl_build.com:210: persistant  ==> persistent
./packages/vms/generate_config_vms_h_curl.com:226: disble  ==> disable
./packages/vms/generate_config_vms_h_curl.com:415: enviroment  ==> environment
./packages/vms/build_vms.com:45: includ  ==> include
./packages/vms/build_vms.com:282: includ  ==> include
./packages/vms/backup_gnv_curl_src.com:110: sav  ==> save
./packages/vms/backup_gnv_curl_src.com:126: sav  ==> save

@vszakats vszakats self-requested a review November 2, 2018 00:26
@danielgustafsson
Copy link
Member Author

Thank you @danielgustafsson! I excluded the vms subdir from my codespell update to avoid messing up anything VMS-related (can't test those), and missed this hidden connection — sorry about that.

Yeah, I fully understand that, I can't test it either but this seems to not make anything worse at least. I simply happened to run across it due to having a stale persistant binary that was no longer hidden by .gitignore after you fixed the spelling, and started digging from there.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagder bagder bagder approved these changes

@vszakats vszakats vszakats approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danielgustafsson @vszakats @bagder