Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows VT Support and UTF-8 output doesn't restore font #3211

Closed
bagder opened this issue Nov 1, 2018 · 4 comments
Closed

Windows VT Support and UTF-8 output doesn't restore font #3211

bagder opened this issue Nov 1, 2018 · 4 comments
Labels
cmdline tool Windows Windows-specific

Comments

@bagder
Copy link
Member

bagder commented Nov 1, 2018

This is very ugly change. Changing console codepage effect console font. Also you probably notice that curl doesn't restore original font.

shoei

@bitcrazed This is NOT right way to show unicode. You should use wide string APIs.

Originally posted by @mattn in #3008 (comment)
@bagder bagder added cmdline tool Windows Windows-specific labels Nov 1, 2018
mattn added a commit to mattn/curl that referenced this issue Nov 1, 2018
@mattn
curl: revert curl#3011 and write UTF-8 in current console code page.
1d39418 
Fixes curl#3211
@mattn mattn mentioned this issue Nov 1, 2018
Closed
mattn added a commit to mattn/curl that referenced this issue Nov 1, 2018
@mattn
curl: write UTF-8 in current console code page.
f62e1ab 
Fixes curl#3211
@bitcrazed
Copy link
Contributor

Thanks for fixing @mattn

@bagder
Copy link
Member Author

bagder commented Nov 1, 2018 •
edited

So, an innocent question from someone not usually on Windows: how annoying is this bug for a typical user? Would you (the plural you, anyone!) say this is a reason enough to do a patch release or can we live with it for six weeks?

@bitcrazed
Copy link
Contributor

My feel for this is that this is fundamentally a cosmetic issue (i.e. I don't think it breaks functionality/behavior, right?), though to what degree is a good question for @mattn.

@mattn
Copy link
Contributor

mattn commented Nov 2, 2018

IMO, This doesn't break functionality but curl harms to console. For example, if we use curl in Vim plugin, console is broken. I strongly wish getting this fix immediately.

terminal6

@bagder bagder closed this as completed in 5bfaa86 Nov 5, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Feb 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
cmdline tool Windows Windows-specific
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattn @bagder @bitcrazed