Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtests: use the local curl for verifying #3198

Closed
wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Oct 31, 2018

... revert the mistaken change brought in commit 8440616.

Reported-by: Alessandro Ghedini
Bug: https://curl.haxx.se/mail/lib-2018-10/0118.html

... revert the mistaken change brought in commit 8440616.

Reported-by: Alessandro Ghedini
Bug: https://curl.haxx.se/mail/lib-2018-10/0118.html
Copy link
Member

@MarcelRaad MarcelRaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! I was just wondering about that too when I tried to build on a fresh machine without curl.

@bagder
Copy link
Member Author

bagder commented Oct 31, 2018

I'm thinking of trying removing the curl tool from the travis image before the tests are run, to make sure this kind of mistake will be caught in the future...

bagder added a commit that referenced this pull request Oct 31, 2018
... to make sure the test suite runs with its newly build tool!

Bug: #3198
@bagder bagder closed this in 8effa8c Oct 31, 2018
@bagder bagder deleted the bagder/runtests-vcurl branch October 31, 2018 12:50
bagder added a commit that referenced this pull request Nov 1, 2018
... to make sure the test suite runs with its newly build tool!

Bug: #3198
xquery pushed a commit to xquery/curl that referenced this pull request Nov 1, 2018
... revert the mistaken change brought in commit 8440616.

Reported-by: Alessandro Ghedini
Bug: https://curl.haxx.se/mail/lib-2018-10/0118.html

Closes curl#3198
bagder added a commit that referenced this pull request Nov 2, 2018
on Linux. To make sure the test suite runs with its newly build tool and
doesn't require an external one present.

Bug: #3198
Closes #3200
@lock lock bot locked as resolved and limited conversation to collaborators Jan 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants