Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choose proper settings compiling with Sun C++ #3181

Closed
wants to merge 1 commit into from
Closed

Choose proper settings compiling with Sun C++ #3181

wants to merge 1 commit into from

Conversation

randomswdev
Copy link
Contributor

system.h selects the proper Sun settings when __SUNPRO_C is defined. The Sun compiler does not define it when compiling C++ files.
I'm adding a check also on __SUNPRO_CC to allow curl to work properly also when used in a C++ project on Sun Solaris.

@randomswdev
Choose proper setting with Sun C++
9482403 
system.h selects the proper Sun settings when __SUNPRO_C is defined. The Sun compiler does not define it when compiling C++ files.
I'm adding a check also on __SUNPRO_CC to allow curl to work properly also when used in a C++ project on Sun Solaris.
@bagder
Copy link
Member

bagder commented Oct 27, 2018

Thanks, seems totally reasonable!

@bagder
Copy link
Member

bagder commented Oct 27, 2018

Thanks!

@bagder bagder closed this in 9d8dad1 Oct 27, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@randomswdev @bagder