Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MinGW build #3113

Closed
wants to merge 2 commits into from
Closed

Fix MinGW build #3113

wants to merge 2 commits into from

Conversation

MarcelRaad
Copy link
Member

  • define NOGDI in addition to WIN32_LEAN_AND_MEAN on Windows
  • don't use GetTickCount64 and InitializeCriticalSectionEx on classic MinGW

This fixes 1) the MinGW CMake build and 2) MinGW targeting Windows Vista or later.

@MarcelRaad
Windows: fixes for MinGW targeting Windows Vista
6d409bd 
Classic MinGW has neither InitializeCriticalSectionEx nor
GetTickCount64, independent of the target Windows version.

Closes
@MarcelRaad
curl_setup: define NOGDI on Windows
496fba0 
This avoids an ERROR macro clash between <wingdi.h> and <arpa/tftp.h>
on MinGW.

Closes
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Oct 9, 2018
@MarcelRaad
curl_setup: define NOGDI on Windows
673795f 
This avoids an ERROR macro clash between <wingdi.h> and <arpa/tftp.h>
on MinGW.

Closes curl#3113
@MarcelRaad MarcelRaad closed this in 940e1c1 Oct 9, 2018
@MarcelRaad MarcelRaad deleted the fix_mingw_build branch October 9, 2018 06:35
@MarcelRaad
Copy link
Member Author

Thanks for the review!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vszakats vszakats vszakats approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarcelRaad @vszakats