On 14 Sep 2018, at 10:28, Kruzya ***@***.***> wrote: https://github.com/curl/curl/blob/5bd8c389a3625e5c3eed265942d4c5b1e7e5d117/docs/examples/getinmemory.c#L45-L50 realloc can return null if he can't extend the memory. This case here envisaged, but... realloc doesn't clean memory. We got a memory leak if realloc return null. If we open realloc documentation, we can see: A null-pointer indicates that the function failed to allocate storage, and thus the block pointed by ptr was not modified.

On 14 Sep 2018, at 10:34, Daniel Gustafsson ***@***.***> wrote: > On 14 Sep 2018, at 10:28, Kruzya ***@***.***> wrote: > > https://github.com/curl/curl/blob/5bd8c389a3625e5c3eed265942d4c5b1e7e5d117/docs/examples/getinmemory.c#L45-L50 > realloc can return null if he can't extend the memory. This case here envisaged, but... > realloc doesn't clean memory. We got a memory leak if realloc return null. > > If we open realloc documentation, we can see: > > A null-pointer indicates that the function failed to allocate storage, and thus the block pointed by ptr was not modified. This is not actually a memory leak as the input pointer isn’t left dangling. The pointer which wasn’t reallocated will subsequently be freed as the main function exits (line 109) unless I’m misreading this.

On 14 Sep 2018, at 23:31, Kruzya ***@***.***> wrote: Ok, I create PR later.