Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cookies: Remove redundant expired check #2962

Closed
wants to merge 1 commit into from
Closed

cookies: Remove redundant expired check #2962

wants to merge 1 commit into from

Conversation

danielgustafsson
Copy link
Member

Expired cookies have already been purged with a later expiration time before this check via remove_expired(), so remove the redundant check.

@danielgustafsson
cookies: Remove redundant expired check
cd8726a 
Expired cookies have already been purged at a later expiration time
before this check, so remove the redundant check.
bagder
bagder approved these changes Sep 9, 2018
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@bagder
Copy link
Member

bagder commented Sep 10, 2018

Thanks!

@bagder bagder closed this in c3654df Sep 10, 2018
falconindy pushed a commit to falconindy/curl that referenced this pull request Sep 10, 2018
@danielgustafsson @falconindy
cookies: Remove redundant expired check
aba05e7 
Expired cookies have already been purged at a later expiration time
before this check, so remove the redundant check.

closes curl#2962
@lock lock bot locked as resolved and limited conversation to collaborators Dec 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielgustafsson @bagder