Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CURLOPT_UPLOAD_BUFFERSIZE: set upload buffer size #2896

Closed
wants to merge 1 commit into from
Closed

CURLOPT_UPLOAD_BUFFERSIZE: set upload buffer size #2896

wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Aug 18, 2018

This is step 3 of #2888.

Fixes #2888

@bagder bagder added feature-window A merge of this requires an open feature window performance labels Aug 18, 2018
@bagder
Copy link
Member Author

bagder commented Aug 21, 2018

When this lands, we can also consider upping the size that the curl tool uses - since it only does one handle at a time it can easily afford using a larger buffer.

danielgustafsson
danielgustafsson reviewed Sep 3, 2018
View reviewed changes
Copy link
Member

@danielgustafsson danielgustafsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small typo found

docs/libcurl/opts/CURLOPT_UPLOAD_BUFFERSIZE.3 Outdated
This is just treated as a request, not an order. You cannot be guaranteed to
actually get the given size.

The ulpoad buffer size is by default 64 kilobytes. The maximum buffer size
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/ulpoad/upload/

@bagder bagder force-pushed the bagder/CURLOPT_UPLOAD_BUFFERSIZE branch from 4910cea to 23e421b Compare September 3, 2018 21:30
@bagder
Copy link
Member Author

bagder commented Sep 3, 2018

Thanks, fixed that and rebased.

@bagder bagder removed the feature-window A merge of this requires an open feature window label Sep 6, 2018
@bagder bagder closed this in 2825f46 Sep 6, 2018
@bagder bagder deleted the bagder/CURLOPT_UPLOAD_BUFFERSIZE branch September 6, 2018 08:55
falconindy pushed a commit to falconindy/curl that referenced this pull request Sep 10, 2018
@bagder @falconindy
CURLOPT_UPLOAD_BUFFERSIZE: set upload buffer size
7318056 
This is step 3 of curl#2888.

Fixes curl#2888
Closes curl#2896
@lock lock bot locked as resolved and limited conversation to collaborators Dec 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danielgustafsson danielgustafsson danielgustafsson left review comments

Assignees
No one assigned
Labels
performance
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bagder @danielgustafsson