Silence GCC 8 cast-function-type warnings #2860
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
approved these changes
Aug 10, 2018
|
This is the same type of warning that was suppressed in fc3743c. I think it would make sense to silence the warnings the same way (probably by using the new |
|
Thanks, I'll do that! |
MarcelRaad
force-pushed
the
gcc8-warnings
branch
from
c5802f1
to
ee7c44a
Compare
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
Aug 10, 2018
Pointed-out-by: Rikard Falkeborn Closes curl#2860
On Windows, casting between unrelated function types is fine and sometimes even necessary, so just use an intermediate cast to (void (*) (void)) to silence the warning as described in [0]. [0] https://gcc.gnu.org/onlinedocs/gcc-8.1.0/gcc/Warning-Options.html Closes curl#2860
Pointed-out-by: Rikard Falkeborn Closes curl#2860
MarcelRaad
force-pushed
the
gcc8-warnings
branch
from
ee7c44a
to
3875543
Compare
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
Aug 11, 2018
Pointed-out-by: Rikard Falkeborn Closes curl#2860
xquery
pushed a commit
to xquery/curl
that referenced
this pull request
Sep 3, 2018
On Windows, casting between unrelated function types is fine and sometimes even necessary, so just use an intermediate cast to (void (*) (void)) to silence the warning as described in [0]. [0] https://gcc.gnu.org/onlinedocs/gcc-8.1.0/gcc/Warning-Options.html Closes curl#2860
xquery
pushed a commit
to xquery/curl
that referenced
this pull request
Sep 3, 2018
Pointed-out-by: Rikard Falkeborn Closes curl#2860
falconindy
pushed a commit
to falconindy/curl
that referenced
this pull request
Sep 10, 2018
On Windows, casting between unrelated function types is fine and sometimes even necessary, so just use an intermediate cast to (void (*) (void)) to silence the warning as described in [0]. [0] https://gcc.gnu.org/onlinedocs/gcc-8.1.0/gcc/Warning-Options.html Closes curl#2860
falconindy
pushed a commit
to falconindy/curl
that referenced
this pull request
Sep 10, 2018
Pointed-out-by: Rikard Falkeborn Closes curl#2860
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, casting between unrelated function types is fine and
sometimes even necessary, so just use an intermediate cast to
(void (*) (void)) to silence the warning as described in [0].
[0] https://gcc.gnu.org/onlinedocs/gcc-8.1.0/gcc/Warning-Options.html