Remove (some) unused macros #2852
Conversation
|
Thanks! |
The macro seems to never have been used. Closes #2852
The macro has never been used, and it there is not really any place where it would make sense to add timing checks. Closes #2852
The macro seems to never have been used. Closes curl#2852
The macro has never been used, and it there is not really any place where it would make sense to add timing checks. Closes curl#2852
The macro seems to never have been used. Closes curl#2852
The macro has never been used, and it there is not really any place where it would make sense to add timing checks. Closes curl#2852
|
Perhaps unrelated, but I recently discovered that to my surprise if I post some binary data using libcurl it's posted with |
How's it related to this issue? --data-binary doesn't do any processing with the provided data but that does not imply octet stream, as far as I see it. |
- Advise user that --data-binary sends a default content type of x-www-form-urlencoded, and to have the data treated as arbitrary binary data by the server set the content-type header to octet-stream. Ref: curl#2852 (comment) Closes #xxxx
- Advise user that --data-binary sends a default content type of x-www-form-urlencoded, and to have the data treated as arbitrary binary data by the server set the content-type header to octet-stream. Ref: #2852 (comment) Closes #3085
It's not related, but I noticed that |
I gave Clangs -Wunused-macros a go and it showed a couple of warnings. IMO the warning is far too noisy to turn on for normal builds (I don't think it is not worth conditionally defining certain macros depending on which platform/compiler/configuration is used, and it'd be silly to remove i.e. CURL_MASK_SCHAR from warnless.c even though it's not used since just about every other MASK exists and is used). The macros in this PR should be fine to remove. Perhaps I could have just squashed the commits, but one at the time makes it possible to be more verbose in the commit message. :)