http2: several cleanups #2751
Closed
http2: several cleanups #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bagder
commented
Jul 16, 2018
bagder
commented
- separate easy handle from connections better
- added asserts on a number of places
- added sanity check of pipelines for debug builds
- separate easy handle from connections better - added asserts on a number of places - added sanity check of pipelines for debug builds
bagder
force-pushed
the
bagder/http2-data-conn-separations
branch
from
cb984a6
to
a248e62
Compare
... the protocol is doing read/write a lot, so it needs to write often even when downloading. A more proper fix could check for eactly when it wants to write and only ask for it then.
|
The smb fix is also split off and will be merged separately in #2768 - but without that fix, the event-based tests will hang when this branch is tested. |
xquery
pushed a commit
to xquery/curl
that referenced
this pull request
Aug 9, 2018
- separate easy handle from connections better - added asserts on a number of places - added sanity check of pipelines for debug builds Closes curl#2751
falconindy
pushed a commit
to falconindy/curl
that referenced
this pull request
Sep 10, 2018
- separate easy handle from connections better - added asserts on a number of places - added sanity check of pipelines for debug builds Closes curl#2751
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.