Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Remove unused #2711

Closed
wants to merge 2 commits into from
Closed

CMake: Remove unused #2711

wants to merge 2 commits into from

Conversation

ruslo
Copy link
Contributor

@ruslo ruslo commented Jul 5, 2018

No description provided.

@bagder bagder added the cmake label Jul 5, 2018
jzakrzewski
jzakrzewski reviewed Jul 5, 2018
View reviewed changes
CMakeLists.txt Outdated
@@ -309,13 +309,13 @@ if(WIN32 OR CMAKE_USE_DARWINSSL OR CMAKE_USE_WINSSL OR CMAKE_USE_MBEDTLS)
endif()
option(CMAKE_USE_OPENSSL "Use OpenSSL code. Experimental" ${openssl_default})

collect_true(enabled_ssl_options enabled_ssl_options_count
count_true(num
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the scope of the variable, calling it "num" is probably not such a good idea. I'd rather leave the old name here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@ruslo
CMake: Remove unused 'output_var' from 'collect_true'
f322572 
Variable 'output_var' is not used and can be removed.
Function 'collect_true' renamed to 'count_true'.
@bagder
Copy link
Member

bagder commented Jul 6, 2018

Thanks!

@bagder bagder closed this in fac400d Jul 6, 2018
@ruslo ruslo deleted the pr.unused branch July 6, 2018 08:11
xquery pushed a commit to xquery/curl that referenced this pull request Jul 6, 2018
@ruslo @xquery
CMake: Remove unused functions
c05165d 
Closes curl#2711
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jzakrzewski jzakrzewski jzakrzewski approved these changes

Assignees
No one assigned
Labels
cmake
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ruslo @bagder @jzakrzewski