Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable multiplexing and HTTP/2 when over HTTPS - by default #2709

Closed
wants to merge 2 commits into from
Closed

enable multiplexing and HTTP/2 when over HTTPS - by default #2709

wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Jul 5, 2018 •
edited

Starting 7.62.0, multiplexing is enabled by default in multi handles.

Enable multiplexing by default mail

Enable HTTP/2 when using HTTPS, by default mail

@bagder bagder added HTTP/2 feature-window A merge of this requires an open feature window labels Jul 5, 2018
@bagder bagder changed the title multiplex: enable by default enable multiplexing and HTTP/2 when over HTTPS - by default Jul 5, 2018
@bagder
Copy link
Member Author

bagder commented Jul 9, 2018

Prerequisites: both #2674 and #2688 need to be fixed accordingly first.

@bagder bagder mentioned this pull request Jul 20, 2018
Closed
@bagder
multiplex: enable by default
4c4c2e6 
Starting 7.62.0, multiplexing is enabled by default in multi handles.
@bagder
url: default to CURL_HTTP_VERSION_2TLS if built h2-enabled
8f214ae
@bagder bagder force-pushed the bagder/multiplex-by-default branch from 93a484d to 8f214ae Compare August 23, 2018 12:35
@bagder bagder closed this in 25fd105 Sep 5, 2018
@bagder bagder deleted the bagder/multiplex-by-default branch September 5, 2018 12:37
@bagder bagder removed the feature-window A merge of this requires an open feature window label Sep 5, 2018
falconindy pushed a commit to falconindy/curl that referenced this pull request Sep 10, 2018
@bagder @falconindy
url: default to CURL_HTTP_VERSION_2TLS if built h2-enabled
30d4a91 
Closes curl#2709
@dscho
Copy link
Contributor

dscho commented Dec 4, 2018

@bagder one of our users is facing a problem with this change, and maybe you have a quick idea how to solve this.

Apparently NTLM is incompatible with HTTP/2 (I could not find any official documentation, but this comment on the Firefox bug tracker seems to suggest so).

However, with the new default in libcurl 7.62.0, it seems that we're upgrading to HTTP/2 before realizing that we cannot authenticate via NTLM, and then the connection is closed without success.

Any idea how to fix this neatly?

@ljani
Copy link

ljani commented Dec 5, 2018 •
edited

Here's the official documentation bit at least with IIS 10:

Windows authentication (NTLM/Kerberos/Negotiate) is not supported with HTTP/2. In this case IIS will fall back to HTTP/1.1.

@dscho
Copy link
Contributor

dscho commented Dec 5, 2018

@ljani indeed. The problem is that cURL somehow does not fall back to HTTP/1.1...

@dscho dscho mentioned this pull request Dec 5, 2018
Closed
@dscho
Copy link
Contributor

dscho commented Dec 5, 2018

I should have known better than to clutter this here, closed ticket with a new concern, so I opened a new ticket: #3341. Let's discuss this over there.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
HTTP/2
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bagder @dscho @ljani