Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCP assert with the libssh backend #2708

Closed
bagder opened this issue Jul 5, 2018 · 0 comments
Closed

SCP assert with the libssh backend #2708

bagder opened this issue Jul 5, 2018 · 0 comments
Labels
crash SCP/SFTP

Comments

@bagder
Copy link
Member

bagder commented Jul 5, 2018

I did this

$ ./src/curl scp://localhost/ -u user:pwd
curl: ssh-libssh.c:1835: myssh_statemach_act: Assertion `sshc->scp_session == ((void *)0)' failed.
Aborted

I expected the following

Some sort of (nicer) run-time message about a failed transfer (since that's a directory and not a file). curl with the libssh2 backend says:

$ ./src/curl scp://localhost/ -u user:pwd
curl: (78) Failed to recv file

curl/libcurl version

git master as of July 5th 2018

curl 7.61.0-DEV (x86_64-pc-linux-gnu) libcurl/7.61.0-DEV (GnuTLS/3.5.18) OpenSSL/1.1.0h zlib/1.2.11 brotli/1.0.5 c-ares/1.14.0 libidn2/2.0.4 libpsl/0.20.2 (+libidn2/2.0.4) libssh/0.7.0/openssl/zlib nghttp2/1.33.0-DEV librtmp/2.3
Release-Date: [unreleased]
Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps pop3 pop3s rtmp rtsp scp sftp smb smbs smtp smtps telnet tftp 
Features: AsynchDNS Debug TrackMemory IDN IPv6 Largefile GSS-API Kerberos SPNEGO NTLM NTLM_WB SSL libz brotli TLS-SRP HTTP2 UnixSockets HTTPS-proxy MultiSSL PSL Metalink

operating system

Debian Linux

Related?

Possibly this, or a related issue was brought up on the mailing list by Martin Galvan

/cc @nmav
bagder added a commit that referenced this issue Jul 5, 2018
@bagder
libssh: goto DISCONNECT state on error, not SSH_SESSION_FREE
2fe34a0 
... because otherwise not everything get closed down correctly.

Fixes #2708
@bagder bagder mentioned this issue Jul 5, 2018
Closed
@bagder bagder closed this as completed in 03d884b Jul 6, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
crash SCP/SFTP
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

libssh: goto DISCONNECT state on error, not SSH_SESSION_FREE curl/curl
1 participant
@bagder