Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curl(1) TLS version 1.3 missing from --tlsv1 description #2692

Closed
andreaso opened this issue Jun 28, 2018 · 1 comment
Closed

curl(1) TLS version 1.3 missing from --tlsv1 description #2692

andreaso opened this issue Jun 28, 2018 · 1 comment
Labels
cmdline tool documentation TLS

Comments

@andreaso
Copy link

The curl(1) man page has the following to say about the --tlsv1 option.

(SSL) Tells curl to use TLS version 1.x when negotiating with a remote TLS server. That means TLS version 1.0, 1.1 or 1.2.

Shouldn't that description also mention version 1.3? Something like the following.

(SSL) Tells curl to use TLS version 1.x when negotiating with a remote TLS server. That means TLS version 1.0, 1.1, 1.2 or 1.3.

curl/libcurl version

curl 7.61.0-DEV (x86_64-pc-linux-gnu) libcurl/7.61.0-DEV OpenSSL/1.1.0g zlib/1.2.11 libidn2/2.0.4 libpsl/0.19.1 (+libidn2/2.0.4) nghttp2/1.30.0 librtmp/2.3
Release-Date: [unreleased]
Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps pop3 pop3s rtmp rtsp smb smbs smtp smtps telnet tftp 
Features: AsynchDNS IDN IPv6 Largefile NTLM NTLM_WB SSL libz TLS-SRP HTTP2 UnixSockets HTTPS-proxy PSL

operating system

Ubuntu 18.04
@bagder
Copy link
Member

bagder commented Jun 28, 2018

That's because so far libcurl doesn't do TLS 1.3 by default, only when you explicitly ask for it. But I think that's more because we haven't remembered to change that since back when we added it with a bit of precaution... I'll file a PR to change this! (both docs and code)

bagder added a commit that referenced this issue Jun 28, 2018
@bagder
openssl: allow TLS 1.3 by default
4bc18e2 
Reported-by: Andreas Olsson
Fixes #2692
@bagder bagder mentioned this issue Jun 28, 2018
Closed
@bagder bagder closed this as completed in 08c845c Jun 29, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Sep 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
cmdline tool documentation TLS
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bagder @andreaso