configure: Add dependent libraries after crypto #2684
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmeister2
commented
Jun 26, 2018
|
|
||
| AC_MSG_CHECKING([OpenSSL linking with -ldl and -lpthread]) | ||
| LIBS="$CLEANLIBS -ldl -lpthread -lcrypto" | ||
| LIBS="$CLEANLIBS -lcrypto -ldl -lpthread" |
There was a problem hiding this comment.
I'm not entirely sure why this suddenly uses CLEANLIBS, where the one above uses LIBS.
There was a problem hiding this comment.
I think maybe the previous one should use CLEANLIBS too, as LIBS already contains "-lcrypto" at that point and it adds it again...
There was a problem hiding this comment.
Yes. I did wonder about that. Worth trying do you think?
There was a problem hiding this comment.
It's not the end of the world, but sure, if you fixup that at the same time as you this fix, I approve!
bagder
approved these changes
Jun 26, 2018
The linker is pretty dumb and processes things left to right, keeping a tally of symbols it hasn't resolved yet. So, we need -ldl to appear after -lcrypto otherwise the linker won't find the dl functions.
cmeister2
force-pushed
the
cmeister2/openssllinkerorder
branch
from
eff0a7b
to
1237081
Compare
bagder
approved these changes
Jun 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linker is pretty dumb and processes things left to right, keeping a
tally of symbols it hasn't resolved yet. So, we need -ldl to appear
after -lcrypto otherwise the linker won't find the dl functions.
This appears to fix the fuzzer build, but would appreciate an extra set of eyes.