Fix maketgz to resolve sed issues on OSX #2660
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Curl build uses maketgz to create release tarball and removes the -DEV string in curl version (e.g. 7.58.0-DEV), else -DEV shows up on command line when curl is run. Upstream provided maketgz works fine on linux but fails on OSX. Problem is with the sed commands that use option -i without an extension. Maketgz expects GNU sed instead of BSD and this simply won't work on OSX. Adding a backup extension .bak after -i fixes this issue Running the script as if on OSX gives this error: sed: -e: No such file or directory Adding a .bak extension resolves it Overall, maketgz uses lot of stuff from the path and ignores environment variables. Might be something the upstream team should consider
|
Thanks! Yes this script was never really designed nor intended for wide-spread use... it assumes a sensible build setup working and present. |
|
Thanks. We use tagged source for our builds. Unfortunately, tagged sources keep -DEV string in the version. So we have to run maketgz to remove the string |
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Jun 15, 2018
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Jun 15, 2018
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Jun 15, 2018
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Jun 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curl build uses maketgz to create release tarball and removes the -DEV string in curl version (e.g. 7.58.0-DEV), else -DEV shows up on command line when curl is run. Upstream provided
maketgz works fine on linux but fails on OSX. Problem is with the sed commands that use option -i without an extension. Maketgz expects GNU sed instead of BSD and this simply won't work on OSX. Adding a backup extension .bak after -i fixes this issue
Running the script as is on OSX gives this error:
sed: -e: No such file or directory
Adding a .bak extension resolves it
Overall, maketgz uses lot of stuff from the path and ignores
environment variables. Might be something the upstream team should
consider