Handle NULL connection pointer passed in by multi.c #2653
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
requested changes
Jun 12, 2018
lib/url.c
Outdated
| @@ -4711,14 +4711,16 @@ CURLcode Curl_init_do(struct Curl_easy *data, struct connectdata *conn) | |||
| { | |||
| struct SingleRequest *k = &data->req; | |||
|
|
|||
| conn->bits.do_more = FALSE; /* by default there's no curl_do_more() to | |||
| use */ | |||
| if (conn != NULL) | |||
There was a problem hiding this comment.
we prefer these to be just if(conn) - and notice the lack of space before the paren!
|
Please explain why we want this to work like this? Are you saying we end up there without a conn pointer during some situation? |
|
This happens when using a multi handle. You can find in multi.c where this gets called with a NULL pointer. |
|
The CI build errors and coverage decrease to 0% are unrelated to these changes. |
|
Ah right, when using HTTP/2... (when |
bagder
approved these changes
Jun 13, 2018
|
Thanks! (I edited it slightly before I merged.) |
|
Thanks badger! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.