Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test 1455 is flaky on travis #2649

Closed
bagder opened this issue Jun 12, 2018 · 0 comments
Closed

test 1455 is flaky on travis #2649

bagder opened this issue Jun 12, 2018 · 0 comments
Labels

Comments

@bagder
Copy link
Member

bagder commented Jun 12, 2018

In several recent travis CI test failures test 1455 has been the culprit.

This test is rather naively using a fixed local port number for a transport. A fixed port number has a fairly high risk of being in use already and then fail the test. An improvement would be to write the test to allow for any port to be used!

@bagder bagder added the tests label Jun 12, 2018
bagder added a commit that referenced this issue Jun 12, 2018
... and make use of that to make 1455 work better without using a fixed
local port number.

Fixes #2649
@bagder bagder closed this as completed in bb9a340 Jun 12, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Sep 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging a pull request may close this issue.

1 participant