fnmatch: use the system one if available #2626
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If configure detects fnmatch to be available, use that instead of our custom one for pattern matching. For standard compliance, to reduce our footprint and to use already well tested and well exercised code. A POSIX fnmatch behaves slightly different than the internal function for a few test patterns currently, and test 1307 is adjusted for this. This is considered a bug.
|
Oh crap. It looks as if the macOS fnmatch function doesn't work exactly like the Linux version in test 1307, causing test failures due to mismatched return codes. How fun. I'll investigate closer tomorrow. So much for POSIX compliance. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If configure detects fnmatch to be available, use that instead of our
custom one for pattern matching. For standard compliance, to reduce our
footprint and to use already well tested and well exercised code.
A POSIX fnmatch behaves slightly different than the internal function
for a few test patterns currently, and test 1307 is adjusted for this.
This is considered a bug.