Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zlib dependency wrong #2606

Closed
asedeno opened this issue May 24, 2018 · 0 comments
Closed

zlib dependency wrong #2606

asedeno opened this issue May 24, 2018 · 0 comments

Comments

@asedeno
Copy link
Contributor

asedeno commented May 24, 2018 •
edited

I tried to build curl 7.60.0 on SunOS 5.10 on sparc. The system zlib.h version is 1.1.4.

https://github.com/curl/curl/blob/master/docs/INTERNALS.md#dependencies says that's good enough

4acc9d3 started using Z_BLOCK instead of Z_SYNC_FLUSH when calling inflate() in lib/content_encoding.c.

https://github.com/madler/zlib/blob/master/ChangeLog#L845-L850 says that Z_BLOCK was added in zlib 1.2.0.5

Z_BLOCK should be tested for, or the dependencies should be updated. I'd prefer the former, as I'm not going to get to update the system zlib here.

SunOS 5.10 Generic_118833-36 sun4u sparc SUNW,UltraAX-i2
@asedeno asedeno mentioned this issue May 25, 2018
Closed
@bagder bagder closed this as completed in d0f1d6c May 25, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@asedeno