New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
curl: show headers in bold #2538
Conversation
The windows console doesn't treat ansi escape codes as special, and as far as I know bold isn't possible You will probably need to do something like this |
The question is perhaps if there's a chance the curl executable might be used in a terminal/console on windows that supports them? If so, that might require us to toggle this feature on/off depending on the terminal type in use... |
Technically, it does support the bold escape sequence in the most recent versions. Except conhost renders it as the bright version of the current colour, not bold. In a completely default cmd-in-conhost window, this means bold is bright white and normal (default) text is (dim) white, so you do still benefit from the colour difference. In a default powershell-in-conhost window, normal (default) text is already bright white and setting 'bold' makes no difference. This would also depend on the curl executable setting the |
2701fe9
to
a62c18d
Compare
Rebased and now disabled on Windows. |
a62c18d
to
1864546
Compare
The feature is only enabled if the output is believed to be a tty. -J: There's some minor differences and improvements in -J handling, as now J should work with -i and it actually creates a file first using the initial name and then *renames* that to the one found in Content-Disposition (if any). -i: only shows headers for HTTP transfers now (as documented). Previously it would also show for pieces of the transfer that were HTTP (for example when doing FTP over a HTTP proxy). -i: now shows trailers as well. Previously they were not shown at all. --libcurl: the CURLOPT_HEADER is no longer set, as the header output is now done in the header callback.
It is enabled by default, so --no-styled-output will switch off the detection/use of bold headers.
1864546
to
c49f486
Compare
There's different behaviour for |
It is expected since I only enabled it for |
I never used
|
From left to right: LilyTerm, Termit, Gnome Terminal, Terminator. |
The feature is only enabled if the output is believed to be a tty.
-J: There's some minor differences and improvements in -J handling, as
now J should work with -i and it actually creates a file first using the
initial name and then renames that to the one found in
Content-Disposition (if any).
-i: only shows headers for HTTP transfers now (as documented).
Previously it would also show for pieces of the transfer that were HTTP
(for example when doing FTP over a HTTP proxy).
-i: now shows trailers as well. Previously they were not shown at all.
--libcurl: the CURLOPT_HEADER is no longer set, as the header output is
now done in the header callback.