Force indentation of lines after an else in checksrc #2532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
does it allow for this: |
|
On 25 Apr 2018, at 22:30, Jay Satiro ***@***.***> wrote:
does it allow for this:
#ifdef MACRO
if(foo) {
bar();
}
else
#endif
{
qux();
}
Yes, it allows for preprocessor lines in the same way as if/while/for.
|
|
This change seems to detect more (unfixed) problems! =) |
|
BTW, the error message seems to use a single right parenthesis weirdly there. |
This extends the INDENTATION case to also handle 'else' statements and require proper indentation on the following line. Also fixes the offending cases found in the codebase.
The INDENTATION message had unbalanced parenthesis, fix by putting the actual indentation level in parenthesis.
danielgustafsson
force-pushed
the
dg-checksrc-else
branch
from
377e334
to
95e2879
Compare
|
Pushed a rebased and updated branch with the missing fix in |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the
INDENTATIONcase to also handleelsestatements and require proper indentation on the following line. Included are also fixes for the offending cases found in the codebase.