Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make sure CFLAGS (including -werror) be used for examples and … #2337

Closed

Conversation

bagder
Copy link
Member

@bagder bagder commented Feb 23, 2018

…tests

... so that the CI and more detects compiler warnings/errors properly!

@bagder
Copy link
Member Author

bagder commented Feb 23, 2018

The #2335 problem is clearly visible now at least!

@bagder bagder added the build label Feb 23, 2018
…tests

... so that the CI and more detects compiler warnings/errors properly!
@bagder bagder force-pushed the bagder/let-werror-propagate-to-tests-and-examples branch from 970ca2f to d39b978 Compare February 23, 2018 23:59
@MarcelRaad
Copy link
Member

I thought that was by design. I like this change, just note that it will need some fixup on MinGW. If I remember correctly, there's one warning in the examples because WinSock has non-standard signatures for send and recv and one warning in the tests about conversions between 32-bit long and 64-bit pointers. I'll try to have a look this afternoon.

@bagder
Copy link
Member Author

bagder commented Feb 24, 2018

it will need some fixup on MinGW

I'm sure that's not the only fixup we need! =) But I figure I should start with making sure the CI builds are all happy and then we can proceed just as usual and fix the problems when we fall over them...

@bagder bagder closed this in 8b0b1a3 Mar 4, 2018
@bagder bagder deleted the bagder/let-werror-propagate-to-tests-and-examples branch March 4, 2018 18:47
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants